Review 10.4 Merged

68123[BUGFIX] Add rowSum to runThroughTemplatesPostProcessing hook parameters

Benni Mack CR +2 V +2 Easy +1 −0 updated 03/01/21, 20:40

Commit message

If the hook is used to add TypoScript, information must also be
added to the rowSum array in order to generate correct cache keys.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 37

  1. Benni Mack commented on patch set 1 03/01/21, 19:25

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 03/01/21, 19:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1099

  3. TYPO3com voted on patch set 1 V -1 03/01/21, 19:39 Completed build in 14m 03s on Mon, 1 Mar, 07:39 PM Test Summary: 1 of 75905 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1148

  4. TYPO3com commented on patch set 1 03/01/21, 19:47 Completed build in 36m 11s on Mon, 1 Mar, 07:47 PM Test Summary: 1 of 75905 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1148

  5. TYPO3com voted on patch set 1 V +1 03/01/21, 19:56 Completed build in 1h 07m 34s on Mon, 1 Mar, 07:56 PM Test Summary: 75416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1148

  6. Benni Mack voted on patch set 1 V +2 CR +2 03/01/21, 20:40

  7. Benni Mack merged patch set 2 03/01/21, 20:40