Review 10.4 Merged

68126[BUGFIX] Do not process dumped file without cropping/sizing

Georg Ringer CR +2 V +2 Easy +28 −20 updated 03/23/21, 12:03

Commit message

When there is no "cv" or "s" parameter we should not perform any
image processing.

This is essential e.g. for accessing PDF files in private storages.
These can technically be processed but should never be since then
the original PDF file becomes inaccessible.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Sebastian Michaelsen +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Sebastian Michaelsen +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Georg Ringer commented on patch set 1 03/02/21, 20:16

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/02/21, 20:25 Completed build in 08m 50s on Tue, 2 Mar, 08:25 PM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1158

  3. core-ci voted on patch set 1 V +1 03/02/21, 20:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1135

  4. Sebastian Michaelsen voted on patch set 1 V +1 CR +1 03/17/21, 06:26

  5. Georg Ringer voted on patch set 1 V +2 CR +2 03/23/21, 12:03

  6. Georg Ringer merged patch set 2 03/23/21, 12:03