Review 10.4 Merged

68128[DOCS] Update outdated information about FlashMessagesViewHelper caching

Christian Kuhn CR +2 V +2 Easy +6 −3 updated 03/03/21, 10:46

Commit message

The ViewHelper does not clear cache since 7.3.0 change:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/34818
Still the documentation states it will clear cache.

Instead users need to take care to properly clear cache.
The background:

FlashMessages often tend to be part of a process and already work with
proper cHash and URLs. Unique URLs often lead to unique output of
FlashMessages.
Under some circumstances flash messages might be created before
redirecting to a generic URL.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Christian Kuhn commented on patch set 1 03/03/21, 10:34

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/03/21, 10:42 Completed build in 07m 51s on Wed, 3 Mar, 10:42 AM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1162

  3. core-ci voted on patch set 1 V +1 03/03/21, 10:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1152

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/03/21, 10:45

  5. Christian Kuhn merged patch set 2 03/03/21, 10:46