Review 10.4 Merged

68129[BUGFIX] Fix TypeError in workspace module

Richard Haeser CR +2 V +2 Easy +13 −9 updated 03/03/21, 19:28

Commit message

Accessing the workspace module while in live workspace
led to a JavaScript TypeError. This is fixed by proper type
checking.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 510

  1. Richard Haeser commented on patch set 1 03/03/21, 18:46

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js
  2. TYPO3com voted on patch set 1 V -1 03/03/21, 18:55 Completed build in 08m 28s on Wed, 3 Mar, 06:55 PM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1163

  3. core-ci voted on patch set 1 V -1 03/03/21, 18:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1158

  4. Richard Haeser uploaded patch set 2 03/03/21, 19:06

  5. Richard Haeser commented on patch set 2 03/03/21, 19:07

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V -1 03/03/21, 19:14 Completed build in 07m 54s on Wed, 3 Mar, 07:14 PM Test Summary: 1 of 75911 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1164

  7. core-ci voted on patch set 2 V +1 03/03/21, 19:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1159

  8. TYPO3com voted on patch set 2 V +1 03/03/21, 19:28 Completed build in 08m 50s on Wed, 3 Mar, 07:28 PM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1165

  9. Richard Haeser voted on patch set 2 V +2 CR +2 03/03/21, 19:28

  10. Richard Haeser merged patch set 3 03/03/21, 19:28