Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
68199[WIP][TASK] Add <typo3-backend-module> element
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 32
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/68199/32 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/68199/32 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 5
- main 68200[WIP][TASK] Implement ConfigurationModule as custom element
- main 68907[WIP][TASK] Select active page/file when opening a deeplink
-
main
68730[WIP][TASK] Add <typo3-backend-button> component
The chain has patch set 6 of 7, the changes above it need a rebase.
-
68199 [WIP][TASK] Add <typo3-backend-module> element This change
-
main
79912[TASK] Render JavaScript modules as script tag if possible
The chain has patch set 17 of 27, the changes above it need a rebase.
Files 64
- Build/Scripts/runTests.sh+2 −0
- Build/Sources/Sass/component/_elementbrowser.scss+9 −4
- Build/Sources/Sass/component/_module.scss+1 −4
- Build/Sources/Sass/element/typo3-backend-module.scssnew+11 −0
- Build/Sources/Sass/module/_page.scss+13 −13
- Build/Sources/Sass/nprogress/_nprogress.scss+8 −5
- Build/Sources/Sass/scaffold/_scaffold.scss+19 −11
- Build/Sources/Sass/variables/_main.scss+2 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/Sass/form.scss+3 −20
- Build/Sources/TypeScript/backend/element/module.tsnew+163 −0
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+18 −56
- Build/Sources/TypeScript/backend/module/iframe.ts+1 −2
- Build/Sources/TypeScript/backend/module/router.ts+1 −1
- Build/Sources/TypeScript/backend/date-time-picker.ts+0 −45
- Build/Sources/TypeScript/backend/document-header.tsdeleted+0 −78
- Build/Sources/TypeScript/backend/document-save-actions.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine-review.ts+1 −1
- Build/Sources/TypeScript/backend/modal.ts+0 −2
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+14 −13
Show 44 more files
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+1 −1
- Build/Sources/TypeScript/viewpage/main.ts+12 −9
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/backend/Resources/Private/Layouts/Module.html+15 −10
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.html+30 −42
- typo3/sysext/backend/Resources/Public/Css/backend.css+23 −22
- typo3/sysext/backend/Resources/Public/JavaScript/element/module.jsnew+96 −0
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/drag-drop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module/iframe.js+1 −2
- typo3/sysext/backend/Resources/Public/JavaScript/module/router.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/document-header.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/document-save-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListGroupCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/InstalledExtensionsCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+6 −6
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/ContentElementsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FormFrameworkCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FrontendLoginCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/IndexedSearchCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/SitemapXmlCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+10 −10
- typo3/sysext/core/Tests/Acceptance/Application/IndexedSearch/IndexedSearchModuleCest.php+9 −9
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/SysNoteCest.php+2 −3
- typo3/sysext/core/Tests/Acceptance/Application/Redirect/RedirectModuleCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.php+2 −2
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Resources/Public/Css/form.css+2 −5
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/info/Resources/Private/Layouts/Module.html+17 −13
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
Review log 3679
Show 2354 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/06/21, 14:47
-
TYPO3com voted on patch set 1 V +1 03/06/21, 14:57 Completed build in 09m 50s on Sat, 6 Mar, 02:57 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9881
-
core-ci voted on patch set 1 V +1 03/06/21, 15:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1220
-
Benjamin Franzke rebased onto patch set 2 03/07/21, 08:32
-
TYPO3com voted on patch set 2 V +1 03/07/21, 08:41 Completed build in 09m 12s on Sun, 7 Mar, 08:41 AM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9897
-
core-ci voted on patch set 2 V +1 03/07/21, 08:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1239
-
Benjamin Franzke rebased onto patch set 3 03/09/21, 19:24
-
TYPO3com voted on patch set 3 V +1 03/09/21, 19:31 Completed build in 06m 40s on Tue, 9 Mar, 07:31 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9988
-
Benjamin Franzke rebased onto patch set 4 03/09/21, 19:32
-
core-ci voted on patch set 3 V +1 03/09/21, 19:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1343
-
TYPO3com voted on patch set 4 V +1 03/09/21, 19:40 Completed build in 07m 03s on Tue, 9 Mar, 07:40 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9991
-
core-ci voted on patch set 4 V +1 03/09/21, 19:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1346
-
Benjamin Franzke rebased onto patch set 5 04/08/21, 11:51
-
TYPO3com voted on patch set 5 V +1 04/08/21, 11:59 Completed build in 07m 39s on Thu, 8 Apr, 11:59 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10548
-
core-ci voted on patch set 5 V +1 04/08/21, 12:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2108
-
Benjamin Franzke rebased onto patch set 6 04/08/21, 12:10
-
TYPO3com voted on patch set 6 V +1 04/08/21, 12:17 Completed build in 06m 47s on Thu, 8 Apr, 12:17 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10552
-
core-ci voted on patch set 6 V +1 04/08/21, 12:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2113
-
Benjamin Franzke rebased onto patch set 7 04/12/21, 16:06
-
TYPO3com voted on patch set 7 V +1 04/12/21, 16:14 Completed build in 07m 51s on Mon, 12 Apr, 04:14 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10620
-
core-ci voted on patch set 7 V +1 04/12/21, 16:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2197
-
Benjamin Franzke rebased onto patch set 8 04/17/21, 07:40
Rebase -
TYPO3com voted on patch set 8 V +1 04/17/21, 07:48 Completed build in 07m 55s on Sat, 17 Apr, 07:48 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10704
-
core-ci voted on patch set 8 V +1 04/17/21, 07:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2303
-
Benjamin Franzke rebased onto patch set 9 04/19/21, 05:10
-
TYPO3com voted on patch set 9 V +1 04/19/21, 05:18 Completed build in 08m 26s on Mon, 19 Apr, 05:18 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10711
-
core-ci voted on patch set 9 V +1 04/19/21, 05:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2316
-
Benjamin Franzke uploaded patch set 10 04/24/21, 04:14
-
TYPO3com voted on patch set 10 V +1 04/24/21, 04:22 Completed build in 08m 20s on Sat, 24 Apr, 04:22 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10850
-
core-ci voted on patch set 10 V -1 04/24/21, 04:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10672
-
Benjamin Franzke rebased onto patch set 11 04/26/21, 22:01
-
core-ci voted on patch set 11 V +1 04/26/21, 22:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10716
-
Benjamin Franzke wrote 04/27/21, 14:54
Topic set to lit -
Benjamin Franzke rebased onto patch set 12 04/27/21, 23:07
-
core-ci voted on patch set 12 V +1 04/27/21, 23:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10811
-
Benjamin Franzke rebased onto patch set 13 04/28/21, 00:04
-
core-ci voted on patch set 13 V +1 04/28/21, 00:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10814
-
Benjamin Franzke rebased onto patch set 14 04/29/21, 06:17
-
core-ci voted on patch set 14 V +1 04/29/21, 06:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10877
-
Benni Mack wrote 11/29/21, 10:07
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 15 11/29/21, 13:20
-
core-ci voted on patch set 15 V +1 11/29/21, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20002
-
Benjamin Franzke uploaded patch set 16 02/20/22, 00:27
-
core-ci voted on patch set 16 V +1 02/20/22, 00:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23915
-
Benjamin Franzke updated the commit message in patch set 17 02/20/22, 00:57
-
core-ci voted on patch set 17 V +1 02/20/22, 01:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23922
-
Benjamin Franzke uploaded patch set 18
V +111/30/23, 15:02 -
core-ci voted on patch set 18 V -1 11/30/23, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50173
-
Benjamin Franzke uploaded patch set 19
V -111/30/23, 17:02 -
core-ci voted on patch set 19 V -1 11/30/23, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50175
-
Benjamin Franzke uploaded patch set 20
V -111/30/23, 19:32 -
core-ci voted on patch set 20 V -1 11/30/23, 19:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50182
-
Benjamin Franzke uploaded patch set 21
V -112/01/23, 06:28 -
core-ci voted on patch set 21 V -1 12/01/23, 06:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50190
-
Benjamin Franzke uploaded patch set 22
V -112/01/23, 06:40 -
core-ci voted on patch set 22 V -1 12/01/23, 06:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50192
-
Benjamin Franzke uploaded patch set 23
V -112/01/23, 16:06 -
core-ci voted on patch set 23 V -1 12/01/23, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50213
-
Benjamin Franzke uploaded patch set 24
V -112/01/23, 19:58 -
core-ci voted on patch set 24 V -1 12/01/23, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50221
-
Benjamin Franzke uploaded patch set 25
V -112/01/23, 22:32 -
core-ci voted on patch set 25 V -1 12/01/23, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50227
-
Benjamin Franzke uploaded patch set 26
V -112/01/23, 22:49 -
core-ci voted on patch set 26 V -1 12/01/23, 23:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50228
-
Benjamin Franzke uploaded patch set 27
V -112/02/23, 04:51 -
core-ci voted on patch set 27 V -1 12/02/23, 05:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50232
-
Benjamin Franzke uploaded patch set 28
V -112/02/23, 09:10 -
core-ci voted on patch set 28 V -1 12/02/23, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50233
-
Benjamin Franzke uploaded patch set 29
V -112/02/23, 10:29 -
core-ci voted on patch set 29 V -1 12/02/23, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50236
-
Benjamin Franzke uploaded patch set 30
V -112/02/23, 11:54 -
core-ci voted on patch set 30 V -1 12/02/23, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50247
-
Benjamin Franzke uploaded patch set 31
V -112/02/23, 12:25 -
core-ci voted on patch set 31 V +1 12/02/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50248
-
Benjamin Franzke uploaded patch set 32
V +112/02/23, 17:06 -
Benjamin Franzke marked it ready for review 12/02/23, 17:09
-
core-ci voted on patch set 32 V -1 12/02/23, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50251
-
core-ci voted on patch set 32 V +1 12/02/23, 17:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50251
-
Benjamin Franzke marked it work in progress 05/30/24, 07:15