Review 10.4 Merged

68212[BUGFIX] Show records in ws preview if live is hidden

Benni Mack CR +2 V +2 Normal +77 −0 updated 03/06/21, 14:21

Commit message

Scenario: A translated content element is hidden in
live, a workspace overlay is not hidden. In workspace
preview, the element should be shown - since it is not
hidden in workspace. This is not the case.
The patch fixes this: The 'base' db call for content
elements ignores hidden & time based restrictions and
elements are sorted out by versionOl() instead, if a
workspace preview is requested.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 511

  1. Benni Mack commented on patch set 1 03/06/21, 11:20

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/06/21, 11:29 Completed build in 07m 57s on Sat, 6 Mar, 11:29 AM Test Summary: 3 of 75914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1167

  3. core-ci voted on patch set 1 V -1 03/06/21, 11:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1213

  4. Benni Mack uploaded patch set 2 03/06/21, 13:40

  5. TYPO3com voted on patch set 2 V -1 03/06/21, 13:50 Completed build in 09m 10s on Sat, 6 Mar, 01:50 PM Test Summary: 3 of 75914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1168

  6. Benni Mack uploaded patch set 3 03/06/21, 13:56

  7. core-ci voted on patch set 2 V -1 03/06/21, 13:57 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1215

  8. TYPO3com voted on patch set 3 V +1 03/06/21, 14:06 Completed build in 10m 15s on Sat, 6 Mar, 02:06 PM Test Summary: 75429 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1169

  9. core-ci voted on patch set 3 V +1 03/06/21, 14:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1218

  10. Benni Mack voted on patch set 3 V +2 CR +2 03/06/21, 14:21

  11. Benni Mack merged patch set 4 03/06/21, 14:21