Review 10.4 Merged

68313[BUGFIX] Use Live Page ID in workspace routing

Benni Mack CR +2 V +2 Easy +6 −3 updated 03/09/21, 17:00

Commit message

When in a workspace, the slug of a workspace'd
page record is properly resolved (good!), but
the versioned ID of the page is used within
the PageArguments.

This is in turn lets TSFE think that the "Page ID"
is the versioned ID, which is wrong (similarly to
the localized page ID / translated page ID), which
always need to be the live Page ID in order to
properly handle records on the page ("pid=live/default ID of the page")

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 35

  1. Benni Mack commented on patch set 1 03/09/21, 13:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/09/21, 13:35 Completed build in 08m 10s on Tue, 9 Mar, 01:35 PM Test Summary: 75427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1178

  3. core-ci voted on patch set 1 V +1 03/09/21, 13:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1319

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/09/21, 17:00

  5. Benni Mack merged patch set 2 03/09/21, 17:00