Review 10.4 Merged

68316[BUGFIX] FormEngine: Validate human-readable selectMultipleSideBySide field

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 03/10/21, 17:25

Commit message

If a selectMultipleSideBySide field has a "minItems" constraint, the
wrong field gets validated which makes it impossible to store a record if
an affected field would fulfill the constraint after a change.

This patch adds an additional validation for the human-readable field.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 03/10/21, 17:02

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/10/21, 17:12 Completed build in 10m 07s on Wed, 10 Mar, 05:12 PM Test Summary: 75471 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1182

  3. core-ci voted on patch set 1 V +1 03/10/21, 17:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1379

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 03/10/21, 17:25

  5. Andreas Kienast merged patch set 2 03/10/21, 17:25