Review 10.4 Merged

68473[BUGFIX] Use correct data for cObj in ClickEnlargeViewHelper

Benni Mack CR +2 V +2 Easy +11 −1 updated 03/17/21, 09:10

Commit message

Set the current content element record as data for the cObj
used to generate the click-enlarge code for images.

This ensures that the default dataWrap used in TypoScript
actually gets the uid of the content element and not the
current page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 03/17/21, 07:41

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/17/21, 07:51 Completed build in 10m 19s on Wed, 17 Mar, 07:51 AM Test Summary: 75969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1237

  3. core-ci voted on patch set 1 V +1 03/17/21, 07:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1621

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/17/21, 09:10

  5. Benni Mack merged patch set 2 03/17/21, 09:10