Review 10.4 Merged

68474[BUGFIX] Use correct type for cache compression setting in install tool

Benni Mack CR +2 V +2 Easy +4 −4 updated 03/17/21, 15:47

Commit message

The DatabaseCachePreset now sets options/compression to `true` instead
of 1. This is necessary because the option is of type boolean in the
backend code.
This fails hard if the backend is validating the option, like the Redis
backend does.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Ingo Fabbri +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 03/17/21, 14:59

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/17/21, 15:10 Completed build in 09m 49s on Wed, 17 Mar, 03:10 PM Test Summary: 75969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1238

  3. Ingo Fabbri voted on patch set 1 CR +1 03/17/21, 15:12

  4. core-ci voted on patch set 1 V +1 03/17/21, 15:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1635

  5. Benni Mack voted on patch set 1 V +2 CR +2 03/17/21, 15:47

  6. Benni Mack merged patch set 2 03/17/21, 15:47