Review 10.4 Merged

68537[DOCS] Replace none working orderBy example

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 03/22/21, 19:30

Commit message

The given example does not work and is replaced by a working example.
Doctrine will add ASC as fallback sorting if no sorting direction is
given, leading to an invalid SQL.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Daniel Goerz commented on patch set 1 03/22/21, 19:06

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/22/21, 19:14 Completed build in 07m 35s on Mon, 22 Mar, 07:14 PM Test Summary: 75864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1254

  3. core-ci voted on patch set 1 V +1 03/22/21, 19:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1770

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 03/22/21, 19:29

  5. Daniel Goerz merged patch set 2 03/22/21, 19:30