Review 10.4 Merged

68592[BUGFIX] Ensure compared values are of same type

Benni Mack CR +2 V +2 Easy +14 −5 updated 03/24/21, 09:05

Commit message

When strict type comparison was introduced to
the OptionViewHelper in #90540, it was not properly
ensured that the values to compare are of same type.

The issue is fixed by always typecasting the selected
value to string, before comparing it to the value in
question, which will always be a string, according to
its type hint.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Benni Mack commented on patch set 1 03/24/21, 08:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/24/21, 08:50 Completed build in 06m 59s on Wed, 24 Mar, 08:50 AM Test Summary: 75882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1255

  3. core-ci voted on patch set 1 V +1 03/24/21, 08:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1802

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/24/21, 09:05

  5. Benni Mack merged patch set 2 03/24/21, 09:05