Review 10.4 Merged

68593[BUGFIX] Fix content element preview for menu types

Benni Mack CR +2 V +2 Normal +43 −30 updated 03/24/21, 09:05

Commit message

With the introduction of fluid styled content in #79622,
the former CType `menu` with its subtypes was splitted
into dedicated content types. Since the content element
preview was not adjusted, it still checked for the `menu`
CType, which did not longer exist in Core, leading to no
preview for any menu type was displayed in page module.

The issue is fixed by adjusting the code to check for the
correct content types, making the preview work again.

This also replaces the last usages of LLL:EXT:lang.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 03/24/21, 08:50

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/24/21, 08:58 Completed build in 07m 29s on Wed, 24 Mar, 08:58 AM Test Summary: 75864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1256

  3. core-ci voted on patch set 1 V +1 03/24/21, 09:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1803

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/24/21, 09:05

  5. Benni Mack merged patch set 2 03/24/21, 09:05