Review 10.4 Merged

68619[BUGFIX] Fix descriptions of selectCheckBox items

Oli Bartsch CR +2 V +2 Normal +98 −28 updated 03/29/21, 09:11

Commit message

With #91008 the grouping and sorting feature was
introduced to the TCA select type. As a consequence,
the select items array key for the help text changed
from `3` to `4`.

The SelectCheckBox now correctly checks the `4`
key for the presence of a description.

In v11 the absence of a title value, which is common
in this scenario, did furthermore lead to TypeError
on rendering the popover. This is fixed by assigning
an empty string as default value on initialization of
the popover options. Otherwise this option would be
initialized as 'undefined' and then trigger the
TypeError on sanitizing.

Additionally the TCA properties special=table,
special=exclude and special=custom are adjusted to
add the correct value as help text to the items array.
The value is now added directly as string, as there
is no need to define the array while only providing
the description.

As a drive-by-change, the itemsProcFuncs of the
dashboard and the MFA component do now also add
the description for their access list field. This
is done because the dashboard initially defined the
description already but had to remove it again due
to this bug, see: #91152. The MFA component also
just hadn't added it because the bug hadn't been
resolved at that time.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 8

Review log 814

  1. Oli Bartsch uploaded patch set 1 03/26/21, 16:19

  2. Julian Mair voted on patch set 1 CR +1 03/26/21, 16:23

  3. TYPO3com voted on patch set 1 V +1 03/26/21, 16:27 Completed build in 07m 31s on Fri, 26 Mar, 04:27 PM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1270

  4. core-ci voted on patch set 1 V +1 03/26/21, 16:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1864

  5. Richard Haeser uploaded patch set 2 03/29/21, 08:54

  6. TYPO3com voted on patch set 2 V -1 03/29/21, 08:54 Completed build in 26s on Mon, 29 Mar, 08:54 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1274

  7. Richard Haeser commented on patch set 2 03/29/21, 08:56

    On it. I cherry picked the change in master but there was already a backport which I didn't saw.
  8. core-ci voted on patch set 2 V -1 03/29/21, 08:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1889

  9. Richard Haeser uploaded patch set 3 03/29/21, 08:57

  10. Richard Haeser voted on patch set 3 V +1 CR +1 03/29/21, 09:04

  11. TYPO3com voted on patch set 3 V +1 03/29/21, 09:04 Completed build in 07m 01s on Mon, 29 Mar, 09:04 AM Test Summary: 75930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1275

  12. core-ci voted on patch set 3 V +1 03/29/21, 09:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1890

  13. Richard Haeser voted on patch set 3 V +2 CR +2 03/29/21, 09:11

  14. Richard Haeser merged patch set 4 03/29/21, 09:11