Review 10.4 Merged

68672[TASK] Update comment removing unused "transport_smtp_port"

Richard Haeser CR +2 V +2 Easy +1 −2 updated 03/30/21, 12:23

Commit message

Fix a broken comment mentioning transport_smtp_port,
it was never used within TYPO3 core. Introduced way back
in 2010, it already documented that the server port has
to be written within transport_smtp_server with a colon.
Update the line of transport_smtp_server to a proper
example by adding colon and port.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Richard Haeser commented on patch set 1 03/30/21, 11:50

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/30/21, 11:58 Completed build in 07m 12s on Tue, 30 Mar, 11:58 AM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1282

  3. core-ci voted on patch set 1 V +1 03/30/21, 12:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1912

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/30/21, 12:23

  5. Christian Kuhn merged patch set 2 03/30/21, 12:23