Review 10.4 Merged

68675[TASK] Add compatibility with Doctrine DBAL 2.13.0

Benni Mack CR +2 V +2 Normal +30 −30 updated 04/01/21, 14:24

Commit message

This change removes some type hints which are invalid with
Doctrine DBAL 2.13.0 / 3.0 (builds forward compatibility),
and some hard logic to bindValue() functionality
which is PDO-specific and not supported anymore, as a
Result object is returned instead of a Statement object
from DB queries.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 812

  1. Benni Mack commented on patch set 1 04/01/21, 09:47

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Database/Connection.php
  2. TYPO3com voted on patch set 1 V -1 04/01/21, 09:48 Completed build in 38s on Thu, 1 Apr, 09:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1286

  3. core-ci voted on patch set 1 V -1 04/01/21, 09:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1959

  4. Benni Mack commented on patch set 2 04/01/21, 09:54

    Published edit on patch set 1.
  5. Benni Mack commented on patch set 2 04/01/21, 09:54

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V +1 04/01/21, 10:02 Completed build in 07m 34s on Thu, 1 Apr, 10:02 AM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1287

  7. core-ci voted on patch set 2 V +1 04/01/21, 10:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1960

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 04/01/21, 13:33

  9. Christian Kuhn commented on patch set 2 04/01/21, 13:34

    nightly is happy with this, too.
  10. Oli Bartsch voted on patch set 2 V +1 CR +1 04/01/21, 14:08

  11. Benni Mack voted on patch set 2 V +2 CR +2 04/01/21, 14:24

  12. Benni Mack merged patch set 3 04/01/21, 14:24