Review 10.4 Merged

68676[TASK] Update XLIFF version to 1.2

Oliver Klee CR +2 V +2 Hard +347 −443 updated 04/18/21, 16:43

Commit message

Update all XLIFF files to use version 1.2, which makes it possible to
use a validation schema.

Also drop the TYPO3-specific XLIFF file IDs (together with the reference
to the corresponding XML namespace) as those are not needed anymore,
but prevented XML validation.

Also drop checking the XLIFF file IDs from the CI jobs as this
does not make sense anymore now.

This change does not fix the discovered validation errors in the XLIFF
files. This will come later in a separate change.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 179

Show 159 more files

Review log 1221

  1. Oliver Klee commented on patch set 1 04/05/21, 15:25

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/gitlab-ci/nightly/integrity.yml * Build/gitlab-ci/pre-merge/integrity.yml * typo3/sysext/backend/Resources/Private/Language/Modules/about.xlf * typo3/sysext/backend/Resources/Private/Language/Modules/locallang_alt_intro.xlf * typo3/sysext/backend/Resources/Private/Language/locallang_mfa.xlf * typo3/sysext/core/Resources/Private/Language/locallang_mfa_provider.xlf * typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xlf * typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xlf * typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xlf
  2. Oliver Klee uploaded patch set 2 04/05/21, 15:30

  3. TYPO3com voted on patch set 2 V -1 04/05/21, 15:31 Completed build in 20s on Mon, 5 Apr, 03:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1289

  4. TYPO3com voted on patch set 1 V -1 04/05/21, 15:32 Completed build in 07m 26s on Mon, 5 Apr, 03:32 PM Test Summary: 12 of 76431 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1288

  5. Oliver Klee uploaded patch set 3 04/05/21, 15:36

  6. Oliver Klee uploaded patch set 4 04/05/21, 15:42

  7. Oliver Klee marked it ready for review 04/05/21, 15:43

  8. TYPO3com voted on patch set 3 V -1 04/05/21, 15:43 Completed build in 07m 43s on Mon, 5 Apr, 03:43 PM Test Summary: 12 of 76431 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1290

  9. TYPO3com voted on patch set 4 V +1 04/05/21, 15:50 Completed build in 07m 41s on Mon, 5 Apr, 03:50 PM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1291

  10. core-ci voted on patch set 4 V +1 04/05/21, 15:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2025

  11. Oliver Klee uploaded patch set 5 04/05/21, 16:19

  12. Oliver Klee voted on patch set 5 V +1 CR +1 04/05/21, 16:19

  13. TYPO3com voted on patch set 5 V +1 04/05/21, 16:26 Completed build in 07m 15s on Mon, 5 Apr, 04:26 PM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1292

  14. core-ci voted on patch set 5 V +1 04/05/21, 16:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2026

  15. Xavier Perseguers voted on patch set 5 V +1 CR +1 04/07/21, 05:32

  16. Oliver Klee uploaded patch set 6 04/07/21, 20:39

  17. Oliver Klee commented on patch set 6 V +1 CR +1 04/07/21, 20:40

    rebased
  18. TYPO3com voted on patch set 6 V +1 04/07/21, 20:47 Completed build in 08m 06s on Wed, 7 Apr, 08:47 PM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1298

  19. core-ci voted on patch set 6 V +1 04/07/21, 20:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2086

  20. Georg Ringer voted on patch set 6 V +2 CR +2 04/18/21, 16:43

  21. Georg Ringer merged patch set 7 04/18/21, 16:43