Review 10.4 Merged

68732[BUGFIX] Do not log failed HMAC validation from forms

Anja Leichsenring CR +2 V +2 Easy +8 −2 updated 04/07/21, 07:41

Commit message

When a HMAC of a submitted form is invalid, TYPO3 throws
a BadRequestException which is logged to sys_log and logfiles.
Those invalid HMAC validation errors occur when the values
of the hidden fields tx_extension[__trustedProperties]
(extbase) or tx_form_formframework[form-id][__state] (ext:form)
are manipulated.

Since a TYPO3 site owner has no reasonable possibility to
prevent tampered form submissions and in order to keep logs
clean from errors due to illegal requests, the exceptions
are now not logged any more.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Xavier Perseguers +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Anja Leichsenring commented on patch set 1 04/06/21, 16:28

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/06/21, 16:36 Completed build in 07m 59s on Tue, 6 Apr, 04:36 PM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1293

  3. core-ci voted on patch set 1 V +1 04/06/21, 16:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2054

  4. Xavier Perseguers voted on patch set 1 V +1 CR +1 04/07/21, 05:34

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 04/07/21, 07:41

  6. Anja Leichsenring merged patch set 2 04/07/21, 07:41