Review 10.4 Merged

68736[BUGFIX] Re-add support for existing prepared statements

Benni Mack CR +2 V +2 Easy +27 −14 updated 04/09/21, 19:58

Commit message

The lowlevel bindValue() API is re-introduced in a way that
supports both Doctrine 3.0 and Doctrine 2.10 (for TYPO3 v10)
by checking for the ->getIterator() method on the ForwardCompatibility\Result
object.

For SQLite support, the use of the positional parameters is needed,
as Doctrine DBAL does not support named parameters for manually
wired bound values with SQLite3.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 35

  1. Benni Mack commented on patch set 1 04/09/21, 16:02

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/09/21, 16:09 Completed build in 07m 48s on Fri, 9 Apr, 04:09 PM Test Summary: 75948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1303

  3. core-ci voted on patch set 1 V +1 04/09/21, 16:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2147

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/09/21, 19:58

  5. Benni Mack merged patch set 2 04/09/21, 19:58