Review 10.4 Merged

68813[BUGFIX] Reload page module after deleting content

Benni Mack CR +2 V +2 Easy +3 −2 updated 04/19/21, 08:02

Commit message

The page module is now being reloaded when
deleting a content element via the context menu.

Side note: Since there are a lot of functionalities
in the module, e.g. translation, it isn't sufficient to
just remove the element from DOM, like it's done in
recordlist.
The whole module needs to be reloaded / reinitialized.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 610

  1. Benni Mack commented on patch set 1 04/16/21, 12:29

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenuActions.ts * typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js
  2. Oli Bartsch uploaded patch set 2 04/16/21, 12:39

  3. TYPO3com voted on patch set 1 V -1 04/16/21, 12:40 Completed build in 11m 18s on Fri, 16 Apr, 12:40 PM Test Summary: 75954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1315

  4. TYPO3com voted on patch set 2 V +1 04/16/21, 12:48 Completed build in 09m 19s on Fri, 16 Apr, 12:48 PM Test Summary: 75954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1318

  5. core-ci voted on patch set 1 V -1 04/16/21, 12:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2287

  6. core-ci voted on patch set 2 V +1 04/16/21, 12:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2290

  7. Benni Mack commented on patch set 2 04/16/21, 13:54

    This change is ready for review.
  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/16/21, 14:11

  9. Benni Mack voted on patch set 2 V +2 CR +2 04/19/21, 08:02

  10. Benni Mack merged patch set 3 04/19/21, 08:02