68814[BUGFIX] Restore altIcons TSconfig option
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+23 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+2 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+3 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+55 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+19 −2
- typo3/sysext/core/Documentation/Changelog/10.4.x/Important-73227-TSconfigOptionAltIconsRestored.rstnew+32 −0
Review log 59
-
Benni Mack commented on patch set 1 04/16/21, 12:38
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/FormDataProvider/TcaLanguage.php * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php -
TYPO3com voted on patch set 1 V -1 04/16/21, 12:38 Completed build in 12s on Fri, 16 Apr, 12:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1316
-
Benni Mack commented on patch set 2 04/16/21, 12:38
Published edit on patch set 1. -
Benni Mack commented on patch set 2 04/16/21, 12:38
This change is ready for review. -
TYPO3com voted on patch set 2 V +1 04/16/21, 12:47 Completed build in 08m 35s on Fri, 16 Apr, 12:47 PM Test Summary: 75960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1317
-
core-ci voted on patch set 1 V -1 04/16/21, 12:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2288
-
core-ci voted on patch set 2 V +1 04/16/21, 12:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2289
-
Benni Mack voted on patch set 2 V +2 CR +2 04/16/21, 13:01
-
Benni Mack merged patch set 3 04/16/21, 13:02