Review 10.4 Merged

68814[BUGFIX] Restore altIcons TSconfig option

Benni Mack CR +2 V +2 Normal +134 −4 updated 04/16/21, 13:02

Commit message

In #35891 a feature was introduced, which allowed to
override the icon of select items via Page TSconfig.

This feature however did more or less never see the LTS
release, since it was almost completely removed in #67006
again.

Only SelectMultipleSideBySide provided this feature until
https://review.typo3.org/c/Packages/TYPO3.CMS/+/50879/.

It's now restored, using the original configuration path.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 59

  1. Benni Mack commented on patch set 1 04/16/21, 12:38

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/FormDataProvider/TcaLanguage.php * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php
  2. TYPO3com voted on patch set 1 V -1 04/16/21, 12:38 Completed build in 12s on Fri, 16 Apr, 12:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1316

  3. Benni Mack commented on patch set 2 04/16/21, 12:38

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 04/16/21, 12:38

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 04/16/21, 12:47 Completed build in 08m 35s on Fri, 16 Apr, 12:47 PM Test Summary: 75960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1317

  6. core-ci voted on patch set 1 V -1 04/16/21, 12:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2288

  7. core-ci voted on patch set 2 V +1 04/16/21, 12:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2289

  8. Benni Mack voted on patch set 2 V +2 CR +2 04/16/21, 13:01

  9. Benni Mack merged patch set 3 04/16/21, 13:02