Review 10.4 Merged

68816[BUGFIX] Replace duplicated form attributes in LinkBrowser

Richard Haeser CR +2 V +2 Easy +1 −1 updated 04/19/21, 08:30

Commit message

The form to update an already existing link in the
LinkBrowser used the same name and id as the
form for "Additional Attributes". This now leads
to a JavaScript warning being emitted.

The issue is fixed by replacing the duplicated name
and id attribute.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 59

  1. Richard Haeser commented on patch set 1 04/19/21, 07:52

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/recordlist/Resources/Private/Layouts/LinkBrowser.html
  2. TYPO3com voted on patch set 1 V +1 04/19/21, 08:02 Completed build in 09m 50s on Mon, 19 Apr, 08:02 AM Test Summary: 75960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1320

  3. core-ci voted on patch set 1 V +1 04/19/21, 08:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2321

  4. Oli Bartsch uploaded patch set 2 04/19/21, 08:15

  5. Richard Haeser commented on patch set 2 04/19/21, 08:19

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V +1 04/19/21, 08:23 Completed build in 08m 04s on Mon, 19 Apr, 08:23 AM Test Summary: 75960 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1321

  7. core-ci voted on patch set 2 V +1 04/19/21, 08:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2323

  8. Richard Haeser voted on patch set 2 V +2 CR +2 04/19/21, 08:29

  9. Richard Haeser merged patch set 3 04/19/21, 08:30