Review 10.4 Merged

68852[BUGFIX] Display correct message if slug suggestion is modified

Benni Mack CR +2 V +2 Easy +5 −5 updated 04/22/21, 15:11

Commit message

If a user enters a slug proposal, which is already taken by
another page in the same site, the automatically modified
slug is now shown along with the corresponding message.

The actual functionality already existed, but was never used
due to a Bug in the AJAX response.

In addition, the label for the warning message does not have
the base / slug at the very end, so sprintf() must be used
AFTER htmlspecialchars().

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 610

  1. Benni Mack commented on patch set 1 04/21/21, 08:02

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/21/21, 08:10 Completed build in 07m 56s on Wed, 21 Apr, 08:10 AM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1324

  3. core-ci voted on patch set 1 V +1 04/21/21, 08:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2387

  4. Benni Mack commented on patch set 1 04/21/21, 11:16

    InputSlugElement.php:161 Unresolved

    these utility classes do not exist in v10, so we need to solve this differently.
  5. Benni Mack commented on patch set 2 04/22/21, 13:28

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 04/22/21, 13:35 Completed build in 07m 10s on Thu, 22 Apr, 01:35 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1325

  7. core-ci voted on patch set 2 V +1 04/22/21, 14:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10602

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 04/22/21, 15:01

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 04/22/21, 15:10

  10. Oli Bartsch merged patch set 3 04/22/21, 15:11