Review 10.4 Merged

68853[BUGFIX] Re-add highlighting of filter term in Svg Tree

Benni Mack CR +2 V +2 Easy +27 −6 updated 04/26/21, 09:26

Commit message

This change re-adds the highlighting of filter
results in the Svg Trees, which was present
before in the Page Tree before it was built on SVG.

Due to the nature of SVG, it is rather complicated
to color the actual background of the text than the
text itself (using <tspan>), but still, the highlighting
is IMHO better than having no highlighting.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1319

  1. Benni Mack commented on patch set 1 04/23/21, 08:38

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts * typo3/sysext/backend/Resources/Public/Css/backend.css * typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js
  2. Benni Mack marked it ready for review 04/23/21, 08:38

  3. TYPO3com voted on patch set 1 V -1 04/23/21, 08:44 Completed build in 06m 35s on Fri, 23 Apr, 08:44 AM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1327

  4. Benni Mack uploaded patch set 2 04/23/21, 08:45

  5. TYPO3com voted on patch set 2 V +1 04/23/21, 08:52 Completed build in 07m 01s on Fri, 23 Apr, 08:52 AM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1328

  6. core-ci voted on patch set 2 V +1 04/23/21, 08:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10628

  7. Oliver Hader commented on patch set 2 04/23/21, 08:57

    SvgTree.js:1080 Unresolved

    Could be use SecurityUtility here - that would avoid duplicating and describing this code at multiple places
  8. Oliver Hader voted on patch set 2 CR -1 04/23/21, 13:05

  9. Benni Mack uploaded patch set 3 04/23/21, 20:19

  10. TYPO3com voted on patch set 3 V +1 04/23/21, 20:27 Completed build in 07m 03s on Fri, 23 Apr, 08:27 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1330

  11. Oli Bartsch commented on patch set 3 V -1 04/23/21, 20:47

  12. Oli Bartsch uploaded patch set 4 04/23/21, 20:50

  13. TYPO3com voted on patch set 4 V +1 04/23/21, 20:57 Completed build in 06m 58s on Fri, 23 Apr, 08:57 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1331

  14. core-ci voted on patch set 4 V +1 04/23/21, 21:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10663

  15. Oli Bartsch voted on patch set 4 V +1 CR +1 04/23/21, 21:04

  16. Richard Haeser voted on patch set 4 V +1 CR +1 04/26/21, 07:35

  17. Benni Mack voted on patch set 4 V +2 CR +2 04/26/21, 09:24

  18. Benni Mack merged patch set 5 04/26/21, 09:24

  19. Oliver Hader voted on patch set 5 CR +1 04/26/21, 09:26