68853[BUGFIX] Re-add highlighting of filter term in Svg Tree
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Richard Haeser +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_svgtree.scss+8 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+10 −0
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js1+7 −4
- typo3/sysext/core/Tests/Acceptance/Backend/PageTree/PageTreeFilterCest.php+1 −1
Review log 1319
-
Benni Mack commented on patch set 1 04/23/21, 08:38
Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts * typo3/sysext/backend/Resources/Public/Css/backend.css * typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js -
Benni Mack marked it ready for review 04/23/21, 08:38
-
TYPO3com voted on patch set 1 V -1 04/23/21, 08:44 Completed build in 06m 35s on Fri, 23 Apr, 08:44 AM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1327
-
Benni Mack uploaded patch set 2 04/23/21, 08:45
-
TYPO3com voted on patch set 2 V +1 04/23/21, 08:52 Completed build in 07m 01s on Fri, 23 Apr, 08:52 AM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1328
-
core-ci voted on patch set 2 V +1 04/23/21, 08:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10628
-
Oliver Hader commented on patch set 2 04/23/21, 08:57
SvgTree.js:1080UnresolvedCould be use SecurityUtility here - that would avoid duplicating and describing this code at multiple places -
Oliver Hader voted on patch set 2 CR -1 04/23/21, 13:05
-
Benni Mack uploaded patch set 3 04/23/21, 20:19
-
TYPO3com voted on patch set 3 V +1 04/23/21, 20:27 Completed build in 07m 03s on Fri, 23 Apr, 08:27 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1330
-
Oli Bartsch commented on patch set 3 V -1 04/23/21, 20:47
Acceptance tests failed: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10662 -
Oli Bartsch uploaded patch set 4 04/23/21, 20:50
-
TYPO3com voted on patch set 4 V +1 04/23/21, 20:57 Completed build in 06m 58s on Fri, 23 Apr, 08:57 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1331
-
core-ci voted on patch set 4 V +1 04/23/21, 21:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10663
-
Oli Bartsch voted on patch set 4 V +1 CR +1 04/23/21, 21:04
-
Richard Haeser voted on patch set 4 V +1 CR +1 04/26/21, 07:35
-
Benni Mack voted on patch set 4 V +2 CR +2 04/26/21, 09:24
-
Benni Mack merged patch set 5 04/26/21, 09:24
-
Oliver Hader voted on patch set 5 CR +1 04/26/21, 09:26