Review 10.4 Merged

68854[BUGFIX] Check if property is null

Richard Haeser CR +2 V +2 Easy +3 −0 updated 04/27/21, 17:36

Commit message

ObjectAccess::getPropertyPath requires its second parameter to be string,
so it should not be called if the property argument is null
but return null instead as the getPropertyPath method would have done
in earlier versions.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Richard Haeser commented on patch set 1 04/23/21, 12:05

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 04/23/21, 12:12 Completed build in 07m 10s on Fri, 23 Apr, 12:12 PM Test Summary: 75972 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1329

  3. core-ci voted on patch set 1 V +1 04/23/21, 12:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10642

  4. Richard Haeser voted on patch set 1 V +2 CR +2 04/23/21, 12:22

  5. Oliver Klee voted on patch set 1 CR +1 04/23/21, 18:48

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/27/21, 17:36

  7. Christian Kuhn merged patch set 2 04/27/21, 17:36