Review 9.5 Merged

68857[BUGFIX] Do not log failed HMAC validation from forms

Benni Mack CR +2 V +2 Easy +8 −2 updated 04/27/21, 12:37

Commit message

When a HMAC of a submitted form is invalid, TYPO3 throws
a BadRequestException which is logged to sys_log and logfiles.
Those invalid HMAC validation errors occur when the values
of the hidden fields tx_extension[__trustedProperties]
(extbase) or tx_form_formframework[form-id][__state] (ext:form)
are manipulated.

Since a TYPO3 site owner has no reasonable possibility to
prevent tampered form submissions and in order to keep logs
clean from errors due to illegal requests, the exceptions
are now not logged any more.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 04/27/21, 12:07

    Cherry Picked from branch 10.4.
  2. core-ci voted on patch set 1 V +1 04/27/21, 12:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10733

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 04/27/21, 12:26

  4. Benni Mack voted on patch set 1 V +2 CR +2 04/27/21, 12:37

  5. Benni Mack merged patch set 2 04/27/21, 12:37