Review 10.4 Merged

68862[BUGFIX] Avoid text/javascript for HTML doctypes

Oli Bartsch CR +2 V +2 Easy +15 −10 updated 04/27/21, 22:25

Commit message

The PageRenderer `inlineJavaScriptWrap`, used for
wrapping general JavaScript such as spam protection,
is adjusted to remove the  "text/javascript" type in case
the the doctype is not XHTML.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch commented on patch set 1 04/27/21, 21:42

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Page/PageRenderer.php
  2. core-ci voted on patch set 1 V -1 04/27/21, 21:46 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10801

  3. Oli Bartsch uploaded patch set 2 04/27/21, 21:52

  4. core-ci voted on patch set 2 V +1 04/27/21, 22:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10804

  5. Oli Bartsch commented on patch set 2 04/27/21, 22:17

    This change is ready for review.
  6. Oli Bartsch voted on patch set 2 V +2 CR +2 04/27/21, 22:25

  7. Oli Bartsch merged patch set 3 04/27/21, 22:25