Review 10.4 Merged

68863[BUGFIX] Fixed @return annotation

Daniel Goerz CR +2 V +2 Easy +17 −6 updated 04/28/21, 07:05

Commit message

current() returns FALSE if array is empty or internal array pointer is
beyond the end.

Without this change, this currently leads to the following exception:

Return value of TYPO3\CMS\Extbase\Error\Result::getFirstError() must be an
instance of TYPO3\CMS\Extbase\Error\Error, bool returned

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 04/27/21, 21:43

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 04/27/21, 21:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10802

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 04/28/21, 07:05

  4. Daniel Goerz merged patch set 2 04/28/21, 07:05