Review 10.4 Merged

68868[BUGFIX] Return expected value on GU::writeFileToTypo3tempDir success

Riny van Tiggelen CR +2 V +2 Easy +6 −5 updated 04/29/21, 10:37

Commit message

When TYPO3 is in composer mode (var is outside public path),
GeneralUtility::writeFileToTypo3tempDir now returns NULL for
successful operation as stated in the docblock.

Review

  • Code review CR +2 Done
    • Riny van Tiggelen +2
  • Verified V +2 Done
    • Riny van Tiggelen +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Riny van Tiggelen commented on patch set 1 04/29/21, 09:46

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 04/29/21, 10:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10882

  3. Riny van Tiggelen voted on patch set 1 V +2 CR +2 04/29/21, 10:37

  4. Riny van Tiggelen merged patch set 2 04/29/21, 10:37