Review 10.4 Merged

68869[TASK] Add ContainerInterface->get() to dynamicReturnTypeMeta.json

Christian Kuhn CR +2 V +2 Easy +5 −0 updated 04/29/21, 14:55

Commit message

Even though ContainerInterface->get() can return 'mixed', it
returns 'object|null' with our symfony DI based implementation.
To help IDE's object resolving, dynamicReturnTypeMeta.json now
declares an instance of the first argument is returned.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 04/29/21, 14:25

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 04/29/21, 14:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10908

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 04/29/21, 14:55

  4. Christian Kuhn merged patch set 2 04/29/21, 14:55