Review 10.4 Merged

68936[BUGFIX] Type check extbase parameter for array

Benni Mack CR +2 V +2 Easy +43 −3 updated 05/04/21, 13:34

Commit message

If an argument on a plugin namespace is not an array,
Extbase failed hard with an type error exception.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Benni Mack commented on patch set 1 04/30/21, 17:50

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 04/30/21, 18:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10980

  3. Oli Bartsch uploaded patch set 2 05/04/21, 12:23

  4. Oli Bartsch uploaded patch set 3 05/04/21, 12:30

  5. core-ci voted on patch set 2 V +1 05/04/21, 12:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11098

  6. core-ci voted on patch set 3 V +1 05/04/21, 12:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11101

  7. Oliver Klee voted on patch set 3 CR +1 05/04/21, 12:51

  8. Benni Mack voted on patch set 3 V +1 CR +1 05/04/21, 13:29

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 05/04/21, 13:34

  10. Oli Bartsch merged patch set 4 05/04/21, 13:34