69017[TASK] Remove usages of call_user_func() and call_user_func_array()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- crell +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 29
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+1 −1
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+1 −1
- typo3/sysext/core/Classes/Console/CommandApplication.php+1 −1
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+1 −1
- typo3/sysext/core/Classes/Http/AbstractApplication.php+1 −1
- typo3/sysext/core/Classes/Http/Dispatcher.php+2 −2
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+3 −3
- typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php+2 −2
- typo3/sysext/core/Classes/Resource/Filter/FileNameFilter.php2+2 −2
- typo3/sysext/core/Classes/Resource/Search/Result/DriverFilteredSearchResult.php2+2 −2
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+2 −5
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php2+2 −2
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php2+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+1 −1
Show 9 more files
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+2 −4
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php2+1 −1
- typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationTest.php2+1 −1
- typo3/sysext/filelist/Classes/FileFacade.php2+9 −9
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −5
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+1 −1
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php2+1 −1
Review log 1419
-
crell uploaded patch set 1 05/04/21, 17:05
-
core-ci voted on patch set 1 V +1 05/04/21, 17:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11137
-
Benni Mack commented on patch set 1 05/04/21, 18:10
you need to exclude the gitmessage.txt and .run/ddev-typo3.run.xml I guess. -
crell commented on patch set 1 05/04/21, 20:51
Reply
Bah. Why aren't those in .gitignore already? -
crell uploaded patch set 2 05/04/21, 20:55
-
core-ci voted on patch set 2 V +1 05/04/21, 21:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11170
-
Benni Mack voted on patch set 2 V +1 CR +1 05/05/21, 14:36
-
Benjamin Franzke commented on patch set 2 CR -1 05/06/21, 21:47
FileNameFilter.php:35" (if we adapt opening „ to ", then we should also change “ to ").DriverFilteredSearchResult.php:145"GeneralUtility.php:631One call_user_func missed here.FormProtectionFactoryTest.php:93Let's use regular static invocation: FormProtectionFactory::get(...$arguments);LoggerTest.php:162More readable would be: $logger->{$shorthandMethod}('test message')ObjectConverter.php:260$this->objectManager->get(...PropertyMappingConfigurationTest.php:226$this->propertyMappingConfiguration->{$methodToTestForFluentInterface}FileFacade.php:101$this->resource->{$method}(); (also all other cases in this file)RecyclerModuleController.php:126$this->{$action . 'Action'}($request); -
crell uploaded patch set 3 05/07/21, 14:25
-
crell commented on patch set 2 05/07/21, 14:25
Thanks. Issues fixed, and rebased on master for good measure.FileNameFilter.php:35ReplyAckDriverFilteredSearchResult.php:145ReplyAckGeneralUtility.php:631ReplyAckFormProtectionFactoryTest.php:93ReplyI dunno what I was thinking there. Or what the original code was thinking, either. :)LoggerTest.php:162ReplyAckObjectConverter.php:260ReplyAckPropertyMappingConfigurationTest.php:226ReplyAckFileFacade.php:101ReplyAckRecyclerModuleController.php:126ReplyAck -
core-ci voted on patch set 3 V -1 05/07/21, 14:27 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11291
-
crell uploaded patch set 4 05/07/21, 14:33
-
core-ci voted on patch set 4 V +1 05/07/21, 14:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11292
-
Benjamin Franzke voted on patch set 4 CR +1 05/07/21, 19:12
-
Benjamin Franzke uploaded patch set 5 05/07/21, 19:37
-
core-ci voted on patch set 5 V +1 05/07/21, 19:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11299
-
crell voted on patch set 5 CR +1 05/07/21, 20:00
-
Benni Mack voted on patch set 5 V +2 CR +2 05/07/21, 20:14
-
Benni Mack merged patch set 6 05/07/21, 20:14