Issue Task Closed

#94060Replace call_user_func[_array] with direct calls and variadics

Larry Garfield 05/04/21, 17:01 updated 09/07/21, 07:34

Description

Since PHP 5.6, the splat operator (aka variadics) has been able to do everything that call_user_func() and call_user_func_array() do. Being a language construct, though, it’s slightly faster as it skips a function call.

Let’s use it, because the code is usually clearer anyway, as well as a tiny bit faster.

Reviews 1

History 38

  1. Larry Garfield changed description 05/04/21, 17:02

  2. Gerrit Code Review pushed patch set 1 for master to change 69017 status New Under Review 05/04/21, 17:05

  3. Gerrit Code Review pushed patch set 2 for master to change 69017 05/04/21, 20:55

  4. Gerrit Code Review pushed patch set 3 for master to change 69017 05/07/21, 14:25

  5. Gerrit Code Review pushed patch set 4 for master to change 69017 05/07/21, 14:33

  6. Gerrit Code Review pushed patch set 5 for master to change 69017 05/07/21, 19:37

  7. Larry Garfield commented and changed status Under Review Resolved done 0 % 100 % 05/07/21, 20:20

    Applied in changeset commit:3456ae0a791f5369e3a6ff174a6477310ce5cde1.

  8. Benni Mack changed status Resolved Closed 09/07/21, 07:34