Review 10.4 Merged

69115[BUGFIX] Keep unmapped ?type parameter when using PageTypeDecorator

Benni Mack CR +2 V +2 Easy +33 −1 updated 05/10/21, 15:31

Commit message

This change keeps the type parameter (e.g. ?type=13) even
if PageTypeDecorator is used when building URLs but "13" is not
part of the map in the site configuration.

A test is added in order to make sure this functionality
will not break (again), see
https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383
for the original fix without tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 05/10/21, 14:56

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PageTypeDecoratorTest.php
  2. core-ci voted on patch set 1 V -1 05/10/21, 14:58 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11348

  3. Benni Mack uploaded patch set 2 05/10/21, 15:08

  4. core-ci voted on patch set 2 V +1 05/10/21, 15:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11349

  5. Benni Mack marked it ready for review 05/10/21, 15:31

  6. Benni Mack voted on patch set 2 V +2 CR +2 05/10/21, 15:31

  7. Benni Mack merged patch set 3 05/10/21, 15:31