Review 9.5 Merged

69116[BUGFIX] Keep unmapped ?type parameter when using PageTypeDecorator

Benni Mack CR +2 V +2 Easy +33 −1 updated 05/10/21, 19:27

Commit message

This change keeps the type parameter (e.g. ?type=13) even
if PageTypeDecorator is used when building URLs but "13" is not
part of the map in the site configuration.

A test is added in order to make sure this functionality
will not break (again), see
https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383
for the original fix without tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 711

  1. Benni Mack commented on patch set 1 05/10/21, 18:29

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php
  2. Benni Mack commented on patch set 2 05/10/21, 18:30

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 05/10/21, 18:31 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11355

  4. Benni Mack marked it ready for review 05/10/21, 18:32

  5. core-ci voted on patch set 2 V -1 05/10/21, 18:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11356

  6. Benni Mack commented on patch set 3 05/10/21, 18:32

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V -1 05/10/21, 19:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11357

  8. Benni Mack uploaded patch set 4 05/10/21, 19:04

  9. core-ci voted on patch set 4 V +1 05/10/21, 19:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11358

  10. Benni Mack voted on patch set 4 V +2 CR +2 05/10/21, 19:27

  11. Benni Mack merged patch set 5 05/10/21, 19:27