Review 10.4 Merged

69178[BUGFIX] Allow persisting PseudoFileReference via database form finisher

Oliver Hader CR +2 V +2 Easy +9 −0 updated 05/19/21, 06:45

Commit message

To "encapsulate" resources that were uploaded using a form element, a
new PseudoFileReference class was introduced in TYPO3-CORE-SA-2021-002,
extending Extbase's FileReference domain model.

When trying to persist those files using Extbase's PersistenceManager,
the corresponding database table is assumed to be (inferred from class)
`tx_form_mvc_property_typeconverter_pseudofilereference` instead of
correct `sys_file_reference`.

In order to solve this issue, a corresponding mapping for the new domain
model is introduced.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Oliver Hader uploaded patch set 1 05/18/21, 14:31

  2. core-ci voted on patch set 1 V +1 05/18/21, 14:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11626

  3. Georg Ringer uploaded patch set 2 05/18/21, 19:43

  4. core-ci commented on patch set 2 05/18/21, 19:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11635

  5. Oliver Hader voted on patch set 2 V +2 CR +2 05/19/21, 06:45

  6. Oliver Hader merged patch set 3 05/19/21, 06:45