Review 9.5 Merged

69179[BUGFIX] Allow persisting PseudoFileReference via database form finisher

Oliver Hader CR +2 V +2 Easy +13 −1 updated 05/19/21, 15:42

Commit message

To "encapsulate" resources that were uploaded using a form element, a
new PseudoFileReference class was introduced in TYPO3-CORE-SA-2021-002,
extending Extbase's FileReference domain model.

When trying to persist those files using Extbase's PersistenceManager,
the corresponding database table is assumed to be (inferred from class)
`tx_form_mvc_property_typeconverter_pseudofilereference` instead of
correct `sys_file_reference`.

In order to solve this issue, a corresponding mapping for the new domain
model is introduced.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Oliver Hader uploaded patch set 1 05/18/21, 14:39

  2. core-ci voted on patch set 1 V +1 05/18/21, 14:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11628

  3. Georg Ringer uploaded patch set 2 05/18/21, 19:43

  4. core-ci voted on patch set 2 V -1 05/18/21, 19:46 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11636

  5. Andreas Kienast commented on patch set 2 05/18/21, 20:00

    IIRC we need the "classic" TypoScript configuration here.
  6. Oliver Hader uploaded patch set 3 05/19/21, 06:21

  7. Oliver Hader commented on patch set 3 05/19/21, 06:22

    Reply

    Yepp, that's what I had prepared already in PS1 https://review.typo3.org/c/Packages/TYPO3.CMS/+/69179/1 - and it got overridden...
  8. core-ci voted on patch set 3 V +1 05/19/21, 06:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11659

  9. Oliver Hader commented on patch set 3 V +2 CR +2 05/19/21, 15:42

    Received additional feedback via Slack, that it actually solved the problem
  10. Oliver Hader merged patch set 4 05/19/21, 15:42