Review 10.4 Merged

69194[BUGFIX] Use native "recordTitle" for FormEngine title

Benni Mack CR +2 V +2 Easy +1 −3 updated 05/20/21, 17:30

Commit message

The PHP8 incompatible FormEngineUtility::databaseRowCompatibility()
is not needed since TYPO3 v7 LTS, as the TcaRecordTitle
provider has the information stored already.

The usage $this->storeTitle is probably not needed anymore
and can be removed later-on.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack commented on patch set 1 05/20/21, 14:32

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/EditDocumentController.php * typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php
  2. Benni Mack commented on patch set 2 05/20/21, 14:34

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 05/20/21, 14:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11717

  4. Benni Mack marked it ready for review 05/20/21, 14:34

  5. core-ci voted on patch set 2 V -1 05/20/21, 14:46 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11719

  6. Benni Mack commented on patch set 3 05/20/21, 16:50

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 05/20/21, 16:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11730

  8. Christian Kuhn voted on patch set 3 CR +1 05/20/21, 17:08

  9. Benni Mack voted on patch set 3 V +2 CR +2 05/20/21, 17:30

  10. Benni Mack merged patch set 4 05/20/21, 17:30