Review 10.4 Merged

69195[BUGFIX] Check request object in ExtensionComposerStatus

Christian Kuhn CR +2 V +2 Easy +14 −13 updated 05/20/21, 15:12

Commit message

Although the ExtensionComposerStatus report implements the
RequestAwareStatusProviderInterface, there is no guarantee
that a PSR-7 request is passed to getStatus().

To prevent type errors we have to ensure, the request
object is set, before accessing its values.

This patch therefore checks the request object before
adding the returnUrl argument to the query parameters.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 05/20/21, 14:59

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 05/20/21, 15:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11721

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 05/20/21, 15:12

  4. Christian Kuhn merged patch set 2 05/20/21, 15:12