Review 10.4 Merged

69198[BUGFIX] Handle LEFT JOINs in Extbase correctly

Benni Mack CR +2 V +2 Easy +24 −5 updated 05/20/21, 17:46

Commit message

Since Core's query builder now uses correct outer joins
including enable field filters, Extbase can rely on this
behaviour too and therefore does not need to fiddle with
visibility constraints for related tables (e.g. MM) anymore.
Rows are filtered on the database side now already.

This fixes the behaviour for MM relations, where the related
record is disabled/hidden and hence must not be returned as
related record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 05/20/21, 17:29

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 05/20/21, 17:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11732

  3. Benni Mack voted on patch set 1 V +2 CR +2 05/20/21, 17:46

  4. Benni Mack merged patch set 2 05/20/21, 17:46