Review 9.5 Merged

69199[BUGFIX] Handle LEFT JOINs in Extbase correctly

Benni Mack CR +2 V +2 Easy +23 −5 updated 05/20/21, 18:40

Commit message

Since Core's query builder now uses correct outer joins
including enable field filters, Extbase can rely on this
behaviour too and therefore does not need to fiddle with
visibility constraints for related tables (e.g. MM) anymore.
Rows are filtered on the database side now already.

This fixes the behaviour for MM relations, where the related
record is disabled/hidden and hence must not be returned as
related record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 69

  1. Benni Mack commented on patch set 1 05/20/21, 17:46

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php * typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php
  2. Benni Mack commented on patch set 2 05/20/21, 17:48

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 05/20/21, 17:48

  4. core-ci voted on patch set 1 V -1 05/20/21, 17:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11736

  5. core-ci voted on patch set 2 V -1 05/20/21, 17:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11737

  6. Benni Mack commented on patch set 3 05/20/21, 17:54

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 05/20/21, 18:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11738

  8. Benni Mack voted on patch set 3 V +2 CR +2 05/20/21, 18:40

  9. Benni Mack merged patch set 4 05/20/21, 18:40