69199[BUGFIX] Handle LEFT JOINs in Extbase correctly
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/categories.xml+9 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/category-mm.xml+9 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+5 −3
Review log 69
-
Benni Mack commented on patch set 1 05/20/21, 17:46
Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php * typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php -
Benni Mack commented on patch set 2 05/20/21, 17:48
Published edit on patch set 1. -
Benni Mack marked it ready for review 05/20/21, 17:48
-
core-ci voted on patch set 1 V -1 05/20/21, 17:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11736
-
core-ci voted on patch set 2 V -1 05/20/21, 17:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11737
-
Benni Mack commented on patch set 3 05/20/21, 17:54
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 05/20/21, 18:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11738
-
Benni Mack voted on patch set 3 V +2 CR +2 05/20/21, 18:40
-
Benni Mack merged patch set 4 05/20/21, 18:40