Review 10.4 Merged

69273[BUGFIX] Do not reset validation state when validating sections

Anja Leichsenring CR +2 V +2 Easy +5 −3 updated 05/27/21, 19:11

Commit message

Calling `FormEngineValidation.validate()` on a passed section resets the
overall validation state which may cause to mark fields as valid albeit
they aren't.

To solve this issue, the validation state is reset only in case no
specific section was given.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Anja Leichsenring commented on patch set 1 05/27/21, 18:57

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 05/27/21, 19:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11918

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 05/27/21, 19:11

  4. Anja Leichsenring merged patch set 2 05/27/21, 19:11