Review 10.4 Merged

69435[BUGFIX] Fix return annotation of AbstractDomainObject->getUid()

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 06/11/21, 10:43

Commit message

The method `TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject->getUid()`
is declared to return either an int or null, but the annotation mentions
int only, which may cause issues with static code analysis tools.

Therefore, the annotation is adjusted to reflect both return types.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 06/11/21, 10:09

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 06/11/21, 10:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12300

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 06/11/21, 10:43

  4. Andreas Kienast merged patch set 2 06/11/21, 10:43