Review 10.4 Merged

69437[BUGFIX] Fix range handling for eval double

Anja Leichsenring CR +2 V +2 Normal +79 −3 updated 06/15/21, 18:06

Commit message

If a field has a '''double''' eval, '''upper''' and '''lower''' range
checks don't work as expected as the value is always cast to an int
before comparison.

Switching to floor and ceil helps with these edge cases while retaining
the casting to int behaviour.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 06/15/21, 17:55

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 06/15/21, 18:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12462

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 06/15/21, 18:05

  4. Anja Leichsenring merged patch set 2 06/15/21, 18:06