Review 10.4 Merged

69778[BUGFIX] Enable ContextMenu for file mounts and file storages again

Oli Bartsch CR +2 V +2 Normal +3 −154 updated 07/12/21, 16:56

Commit message

The custom ContextMenu ItemProviders for sys_filemounts
and sys_file_storage are removed as they never worked,
because they extended the FileProvider, which uses
the combined identifier as record identifier instead of
the records uid. Also their $itemsConfiguration does not
make any sense. In the end, there is no reason to treat
those record types differently than the rest.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 57

  1. Oli Bartsch commented on patch set 1 07/12/21, 14:44

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/ContextMenuActions.ts * typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js
  2. core-ci voted on patch set 1 V -1 07/12/21, 14:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13244

  3. Oli Bartsch uploaded patch set 2 07/12/21, 16:41

  4. core-ci voted on patch set 2 V +1 07/12/21, 16:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13250

  5. Oli Bartsch commented on patch set 2 07/12/21, 16:56

    This change is ready for review.
  6. Oli Bartsch voted on patch set 2 V +2 CR +2 07/12/21, 16:56

  7. Oli Bartsch merged patch set 3 07/12/21, 16:56