Review 10.4 Merged

70132[BUGFIX] Check whether realpath exists in runTests.sh

Oli Bartsch CR +2 V +2 Easy +8 −1 updated 07/27/21, 10:14

Commit message

#94612 introduced the realpath command for retrieving
the "CORE_ROOT" path. This however leads to execution
failures on MacOS systems, which did not manually install
this command (as it's not installed by default).

To prevent the script from failing on default MacOS systems,
a check for the existence of the realpath command is added.
If not installed, the previous behaviour is used while displaying
a short information.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 07/27/21, 09:59

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 07/27/21, 10:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13801

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 07/27/21, 10:14

  4. Oli Bartsch merged patch set 2 07/27/21, 10:14