70135[BUGFIX] Skip range validation if input value and default are both "0"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1014
-
Benni Mack commented on patch set 1 07/29/21, 15:27
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputDateCest.php -
core-ci voted on patch set 1 V -1 07/29/21, 15:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13885
-
Benni Mack commented on patch set 2 07/29/21, 15:29
Published edit on patch set 1. -
Benni Mack marked it ready for review 07/29/21, 15:29
-
Christian Kuhn commented on patch set 2 CR -1 07/29/21, 15:36
ElementsBasicInputDateCest.php:141Unresolvedthis will fail since styleguide does not have that field in v10. please just skip that ac test change in v10 version (reset file change). -
core-ci voted on patch set 2 V -1 07/29/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13887
-
Benni Mack commented on patch set 3 07/29/21, 15:53
Published edit on patch set 2. -
Benni Mack updated the commit message in patch set 4 07/29/21, 15:53
-
core-ci voted on patch set 3 V +1 07/29/21, 16:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13890
-
core-ci voted on patch set 4 V +1 07/29/21, 16:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/13891
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 07/29/21, 16:19
-
Christian Kuhn voted on patch set 4 CR +1 07/29/21, 16:23
-
Christian Kuhn voted on patch set 4 V +2 CR +2 07/29/21, 19:03
-
Christian Kuhn merged patch set 5 07/29/21, 19:03