70255[BUGFIX] Normalize UTF-8 strings before calling CharsetConverter->specCharsToASCII()
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+3 −3
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+4 −0
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+9 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −0
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+14 −0
Review log 1012
-
Anja Leichsenring commented on patch set 1 08/09/21, 17:34
Cherry Picked from branch master. -
core-ci voted on patch set 1 V +1 08/09/21, 17:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14389
-
Anja Leichsenring rebased onto patch set 2 09/11/21, 07:52
-
core-ci voted on patch set 2 V +1 09/11/21, 07:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16518
-
Benni Mack commented on patch set 2 10/08/21, 08:26
what's with this change? -
Martin Kutschker commented on patch set 2 10/09/21, 19:15
Reply
What is the question? -
Stefan Bürk voted on patch set 2 V +1 CR +1 10/10/21, 13:09
-
Stefan Bürk commented on patch set 2 10/10/21, 13:13
Reply Unresolved
If I remembe right, Anja once asked in core-dev for help/opinion of the backport because she was unsure - which went under silently (Sry Anja if I'm wrong). -
Christian Kuhn commented on patch set 2 10/11/21, 15:01
I think the question is: *merge* or *no merge* of the v10 backport? I don't fully understand impact and risk, the patch does not seem to be be crucially important? If so, I'd rather opt for 'no morge into v10 anymore'? -
Benni Mack wrote 10/22/21, 09:23
Removed cc Benni Mack. -
Anja Leichsenring abandoned the change 10/24/21, 06:59
no backport to 10.4 -
Martin Kutschker commented on patch set 2 10/24/21, 16:40
Unresolved
Has the patch been merged to into v11? After all it DOES fix a bug.