Review 10.4 Merged

70420[BUGFIX] Fix the Formelement selection button on first use

waldhacker CR +2 V +2 Easy +1 −1 updated 08/11/21, 12:10

Commit message

Fix the Formelement selection button on first use. The variable
`propertyData` might be a string and the expression
`getCurrentlySelectedFormElement().get(propertyPath)` can return
an undefined value.
The OR operator `||` is used instead of the nullish coalescing
operator `??` on browser compatibility purpose.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. waldhacker commented on patch set 1 08/11/21, 11:48

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 08/11/21, 11:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14580

  3. Björn Jacob voted on patch set 1 V +1 CR +1 08/11/21, 12:04

  4. waldhacker voted on patch set 1 V +2 CR +2 08/11/21, 12:09

  5. waldhacker merged patch set 2 08/11/21, 12:10