Review 9.5 Merged

70554[BUGFIX] Remove prefixed scriptName from urlPath in PageRouter

Benni Mack CR +2 V +2 Easy +20 −1 updated 08/24/21, 14:26

Commit message

Remove resolved scriptName with leading slash from url in
PageRouter matchRequest method.

This prevent to change the url to a invalid url if
PageTypeSuffix Decorator with .php is used and a page slugs
ends in index.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack commented on patch set 1 08/13/21, 10:47

    Cherry Picked from branch 10.4.
  2. core-ci voted on patch set 1 V +1 08/13/21, 11:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14933

  3. Benni Mack voted on patch set 1 V +2 CR +2 08/13/21, 11:08

  4. Benni Mack merged patch set 2 08/13/21, 11:08

  5. Benni Mack wrote 08/24/21, 14:26

    Created a revert of this change as I558c4764e1e0399b7d92da9be0da83cb36c85cba